Update labels for best practices #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you nest input tags inside of the label tags you are linking them together. This allows users to click on the label (not only the box) and automatically focus onto the input box. Also, this format makes it easier for Screen Readers to identify forms to fill out on your form.
One other good alternative is to use is to use <label for=""> attribute, e.g.:
<label for="firstname"></label>
<input id="firstname" name="firstname" type="text" value="<%= user ? user.get('firstname') : '' %>">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you nest input tags inside of the label tags you are linking them together. This allows users to click on the label (not only the box) and automatically focus onto the input box. Also, this format makes it easier for Screen Readers to identify forms to fill out on your form.
One other good alternative is to use is to use attribute, e.g.: