Fix template reference in modular-backbone example. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Underscore templates no longer accept an initial data object. _.template always returns a function now. Example didn't work with updated underscore.js
|
Awesome work. But did you change the version of underscore that the tutorial is using too? |
|
I didn't include new underscore. The commit will work aither with old and new lilbrary. I've checked the project localy. Now it is working with all the newrest versions of underscore, backbone jQuery and require libraries. Backbone doesn't need to be downloaded from special fork now. Would you like me to include new versions of libraries in the commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underscore templates no longer accept an initial data object. _.template
always returns a function now. Example didn't work with updated
underscore.js