Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: online multiplayer #119

Merged
merged 42 commits into from
Dec 15, 2024
Merged

feat: online multiplayer #119

merged 42 commits into from
Dec 15, 2024

Conversation

thomas-mauran
Copy link
Owner

@thomas-mauran thomas-mauran commented Dec 9, 2024

Online multiplayer

Description

This PR adds a new multiplayer menu allowing players to challenge each other over internet.
We now basically have a game_server in the middle of the 2 players allowing them to exchange the played moves through a TCP stream

Fixes #93 #116

How Has This Been Tested?

Tested manually. Shall add test in the future

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@thomas-mauran thomas-mauran marked this pull request as ready for review December 14, 2024 14:36
@thomas-mauran thomas-mauran self-assigned this Dec 15, 2024
@thomas-mauran thomas-mauran added the enhancement New feature or request label Dec 15, 2024
@thomas-mauran thomas-mauran changed the title Feat/2 players feat: online multiplayer Dec 15, 2024
@thomas-mauran thomas-mauran merged commit 95baabf into main Dec 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Online multiplayer
1 participant