Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SvelteKit-pod]: fix: storybook #650

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[SvelteKit-pod]: fix: storybook #650

wants to merge 2 commits into from

Conversation

iansamz
Copy link
Contributor

@iansamz iansamz commented Dec 14, 2022

Type of change

  • Documentation change
  • Bug fix

Summary of change

Checklist

  • These changes follow the contributing guidelines
  • This starter kit has been approved by the maintainers
  • Changes for this new starter kit are being pushed to an integration branch instead of main
  • All dependencies are version locked
  • This fix resolves #
  • I have verified the fix works and introduces no further errors

@iansamz iansamz requested a review from BigAB December 14, 2022 14:07
@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit b2b6e19
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/6399f92cbdc3150008864eea

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-650.d2zmkukv1jdnvq.amplifyapp.com

@iansamz iansamz self-assigned this Dec 14, 2022
BigAB
BigAB reviewed Dec 14, 2022
View reviewed changes
Copy link

@BigAB BigAB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried to test this, I got these conflicting dep errors:

▶ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @storybook/[email protected]
npm ERR! Found: @storybook/[email protected]
npm ERR! node_modules/@storybook/svelte
npm ERR!   dev @storybook/svelte@"7.0.0-beta.6" from the root project
npm ERR!   @storybook/svelte@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/sveltekit
npm ERR!     dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!   1 more (@storybook/svelte-vite)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @storybook/svelte@">=6.4.20" from @storybook/[email protected]
npm ERR! node_modules/@storybook/addon-svelte-csf
npm ERR!   peerOptional @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/sveltekit
npm ERR!     dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!   @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/svelte-vite
npm ERR!     @storybook/svelte-vite@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/sveltekit
npm ERR!       dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @storybook/[email protected]
npm ERR! node_modules/@storybook/svelte
npm ERR!   peer @storybook/svelte@">=6.4.20" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/addon-svelte-csf
npm ERR!     peerOptional @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/sveltekit
npm ERR!       dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!     @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/svelte-vite
npm ERR!       @storybook/svelte-vite@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!       node_modules/@storybook/sveltekit
npm ERR!         dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/adambarrett/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/adambarrett/.npm/_logs/2022-12-14T15_53_26_834Z-debug-0.log

Do we need to do something here? Other than --force or --legacy-peer-deps I mean?

@iansamz
Copy link
Contributor Author

iansamz commented Dec 15, 2022

When I tried to test this, I got these conflicting dep errors:

▶ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @storybook/[email protected]
npm ERR! Found: @storybook/[email protected]
npm ERR! node_modules/@storybook/svelte
npm ERR!   dev @storybook/svelte@"7.0.0-beta.6" from the root project
npm ERR!   @storybook/svelte@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/sveltekit
npm ERR!     dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!   1 more (@storybook/svelte-vite)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @storybook/svelte@">=6.4.20" from @storybook/[email protected]
npm ERR! node_modules/@storybook/addon-svelte-csf
npm ERR!   peerOptional @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/sveltekit
npm ERR!     dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!   @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/svelte-vite
npm ERR!     @storybook/svelte-vite@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/sveltekit
npm ERR!       dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @storybook/[email protected]
npm ERR! node_modules/@storybook/svelte
npm ERR!   peer @storybook/svelte@">=6.4.20" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/addon-svelte-csf
npm ERR!     peerOptional @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/sveltekit
npm ERR!       dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!     @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/svelte-vite
npm ERR!       @storybook/svelte-vite@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!       node_modules/@storybook/sveltekit
npm ERR!         dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/adambarrett/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/adambarrett/.npm/_logs/2022-12-14T15_53_26_834Z-debug-0.log

Do we need to do something here? Other than --force or --legacy-peer-deps I mean?

I believe there is a way to fix it let me find out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigAB BigAB BigAB approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@iansamz iansamz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iansamz @BigAB