-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #58 #59
base: main
Are you sure you want to change the base?
Fix #58 #59
Conversation
The function already has 5 parameters which is already too many. Is there a way to solve this without adding a 6th? |
I attempted to remove |
There's already an options array. Could this feature be one of the keys on the options array? |
The problem lies with the object casting. It converts $array = array(
'members_to_add' => array(
'[email protected]'
)
); into |
Actually, we'd want the opposite so it doesn't change the existing behavior
|
Ok, I believe this is ready to be reviewed. I have another PR ready for the |
This will allow users to use Views Bulk Operations to add subscribed members to an already-created static segment.
A subsequent mailchimp.module patch for adding users will appear on drupal.org.