Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action workflow to patch SDKs #76

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add GitHub Action workflow to patch SDKs #76

wants to merge 9 commits into from

Conversation

leptos-null
Copy link
Member

@leptos-null leptos-null commented Sep 1, 2024 •
edited
Loading

What does this implement/fix? Explain your changes.

This PR aims to simplify the process to patch an SDK.

In detail, this PR

  • Moves supporting code into tools/ directory (for organizational purpose)
  • Reduces create_patched_sdk.sh parameters from 7 to 4
  • Removes support for using simulator binaries as source for symbols
    • This has been shown to be erroneous due to the simulator not being the same as real devices
  • Uses a fixed set of options to tbd for deterministic results
  • Provides create_patched_sdk_image.sh which can patch an SDK using a dyld_shared_cache file
    • This reduces the need for contributors to need physical access to the device they would like to patch an SDK for
  • Adds a GitHub Actions workflow to patch a requested SDK
    • Downloads an IPSW
    • Finds the dyld_shared_cache
    • Patches SDK using scripts in tools
    • Pushes a branch with the requested SDK

Does this close any currently open issues?

No

Any relevant logs, error output, etc?

Screenshot of workflow run configuration

https://github.com/leptos-null/theos-sdks/actions/runs/10657235003

Any other comments?

No

Where has this been tested?

Operating System: macOS

Platform: Darwin

Target Platform: iphone

Toolchain Version: Xcode 15.4

SDK Version: iPhoneOS17.5

@leptos-null leptos-null marked this pull request as ready for review September 1, 2024 23:23
@leptos-null
Squashed commit
071b2ff 
commit e98d3ff
Author: Leptos <[email protected]>
Date:   Wed Aug 28 15:16:10 2024 -0700

    Build tbd in workflow

commit f9dcc12
Author: Leptos <[email protected]>
Date:   Wed Dec 6 14:48:56 2023 -0800

    Remove old scripts

commit 4b60505
Author: Leptos <[email protected]>
Date:   Mon Dec 4 22:11:30 2023 -0800

    Initial simple scripts to create patched SDKs from IPSW

    Sample:
    $ cd tools
    $ ./create_patched_sdk_image.sh /Volumes/.../System/Library/Caches/com.apple.dyld/dyld_shared_cache_... "$(xcrun --sdk iphoneos --show-sdk-platform-path)" tbd
@leptos-null
Remove the ipsw after extracting to save disk space
6fabf16
@leptos-null
Rename workflow to "Create SDK"
2e41be3
@leptos-null
Explicitly base base SDK to create_patched_sdk_image.sh
acf9474
@leptos-null
Adjust input validation for tools scripts
0dd8df2
@leptos-null
Remove create_patched_sdk.py
d818d9d
@leptos-null
Call create_patched_sdk_image.sh from GitHub Actions workflow
e810900
@leptos-null
Use single brackets only for if statements
5d62c26
@leptos-null
Update file path to create_patched_sdk.sh in README
7cdf30e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leptos-null