Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onyomi-hiragana handlebars #960

Merged
merged 3 commits into from
May 21, 2024
Merged

Add onyomi-hiragana handlebars #960

merged 3 commits into from
May 21, 2024

Conversation

rhgg2
Copy link

@rhgg2 rhgg2 commented May 18, 2024

This pull request adds an onyomi-hiragana handlebars to the Anki card templates. It does exactly what it says.

I also found a typo in the documentation of the existing onyomi/kunyomi handlebars (hiragana and katakana are inverted).

I have made what I hope are all the necessary changes, except that I have not touched anything in the test directory.

* Add onyomi-hiragana handlebars
* Add docs
* Fix typo in documentation of kunyomi/onyomi handlebars
@rhgg2 rhgg2 requested a review from a team as a code owner May 18, 2024 01:09
Copy link
Member

@StefanVukovic99 StefanVukovic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to npm run test:unit:write to update the tests with the new handlebar.

ext/settings.html Show resolved Hide resolved
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to set the version from 35 to 36 in test/options-util.test.js in this area of the file:

        profileCurrent: 0,
        version: 35,
        global: {
            database: {
                prefixWildcardsSupported: false
            }
        }

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/anki The issue or PR is related to Anki integration labels May 18, 2024
rhgg2 and others added 2 commits May 19, 2024 07:49
* Update tests for onyomi-hiragana handlebars
* Fix typo in code
@rhgg2
Copy link
Author

rhgg2 commented May 18, 2024

Thanks for the feedback - I think everything should be in order now with the tests.

@jamesmaa jamesmaa added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@jamesmaa jamesmaa added this pull request to the merge queue May 21, 2024
Merged via the queue into themoeway:master with commit ee04cf6 May 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/anki The issue or PR is related to Anki integration kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants