Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web option to profile switching keybinds #933

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented May 13, 2024

Fixes #931

Allowing profile switching on web makes it so users can switch profiles with a shortcut without having to interact with a popup, the search page, or the yomitan icon.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels May 13, 2024
@Kuuuube Kuuuube marked this pull request as ready for review May 25, 2024 19:13
@Kuuuube Kuuuube requested a review from a team as a code owner May 25, 2024 19:13
@Kuuuube
Copy link
Member Author

Kuuuube commented May 25, 2024

This should be ready now.

Copy link
Member

@StefanVukovic99 StefanVukovic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll probably want to add some visual indicator that the profile got changed later (unless it's here and I don't see it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Support for Switching Language Shortcut!
2 participants