fix:MultiSelect on:change triggered twice

[jumtp]

Closes #1337

📑 Description

where is the bug from ?

update always triggered twice

flowbite-svelte/src/lib/forms/MultiSelect.svelte

Lines 64 to 71 in 6ff61d2

	update: (value: any) => {
	selectItems = items.filter((x) => value.includes(x.value));
	// avoid initial event emitting
	if (value !== inital) {
	node.dispatchEvent(create_custom_event('input', selectItems));
	node.dispatchEvent(create_custom_event('change', selectItems));
	}
	}

How does this PR fix the bug?

<select> was not bind:value and that just <select {value}/>.value is control by functions clearAll、clearThisOption、selectOption.

always triggered twice through clearAll test.

use:init just for update value so i use dispatcher to call on:change.

Status

• Not Completed
• Completed

✅ Checks

• My pull request adheres to the code style of this project
• My code requires changes to the documentation
• I have updated the documentation as required
• I have checked the page with https://validator.unl.edu/
• All the tests have passed
• My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

Summary by CodeRabbit

• New Features
  • Enhanced the MultiSelect component to dispatch events, improving interaction and response within forms.
• Refactor
  • Streamlined event handling in the MultiSelect component for better performance and maintainability.

[vercel]

@jumtp is attempting to deploy a commit to the Themesberg Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The update to the MultiSelect.svelte component focuses on refining event handling by introducing a dispatcher for managing events and adjusting related functions to ensure events are dispatched correctly. This change aims to fix issues such as the double triggering of the change event and simplifies the component by removing outdated functions.

Changes

File	Changes Summary
.../forms/MultiSelect.svelte	Introduced dispatcher, adjusted event logic, removed old functions

Assessment against linked issues

Objective	Addressed	Explanation
Prevent double triggering of change event (#1337)	✅

Poem

🐇💻🌟
In the realm of code where logic threads,
A rabbit hopped, fixing the web's spreads.
"No more doubles," it cheerfully said,
As it tweaked the events, ahead it led.
Celebrate the fix, for clean is the trend!
🎉🐾

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6ff61d2 and b725e5d.

Files selected for processing (1)

• src/lib/forms/MultiSelect.svelte (3 hunks)

Additional comments not posted (5)

src/lib/forms/MultiSelect.svelte (5)

6-8: The setup of the dispatcher using createEventDispatcher is correctly implemented and follows Svelte's best practices.

---

43-45: The refactoring of the selectOption function to use the dispatcher for emitting the 'change' event is well-implemented and should help in preventing the double triggering issue.

---

52-52: Using the dispatcher to emit the 'change' event in the clearAll function is correctly implemented.

---

58-58: The use of the dispatcher in the clearThisOption function to emit the 'change' event is consistent with other changes and correctly implemented.

---

116-116: The refactoring of the hidden select element to directly dispatch an input event on value change is a good improvement, aligning with the overall strategy to streamline event handling.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-svelte	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 6, 2024 10:45am