Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix failing after year 2038 #442

Merged
merged 2 commits into from
Mar 26, 2024
Merged

tests: Fix failing after year 2038 #442

merged 2 commits into from
Mar 26, 2024

Conversation

andy5995
Copy link
Member

For #439

@andy5995 andy5995 added this to the v0.9.3 milestone Mar 25, 2024
@andy5995 andy5995 force-pushed the iss-439 branch 2 times, most recently from ec67d5f to cbab795 Compare March 26, 2024 11:31
@andy5995 andy5995 marked this pull request as ready for review March 26, 2024 11:32
@andy5995 andy5995 force-pushed the iss-439 branch 3 times, most recently from 04ddcc2 to 00a9717 Compare March 26, 2024 11:38
@andy5995
Copy link
Member Author

andy5995 commented Mar 26, 2024

@bmwiedemann Are you able to test this patch easily before I merge it?

I've submitted the patch to the OpenSuse rmw package here https://build.opensuse.org/request/show/1161718

@bmwiedemann
Copy link
Contributor

It passes the test now, but I still see room for improvement. E.g.
long prev_time = atol(time_prev);
will use 32-bit integers on 32-bit platforms - armv7 (Raspberry Pi) is the most common one.
Better use long long and atoll instead.

@andy5995 andy5995 mentioned this pull request Mar 26, 2024
@andy5995 andy5995 merged commit f5262a3 into master Mar 26, 2024
15 of 16 checks passed
@andy5995 andy5995 deleted the iss-439 branch March 26, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants