Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: target es2018 #636

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix: target es2018 #636

merged 1 commit into from
Jun 28, 2023

Conversation

thebuilder
Copy link
Owner

Closes #635

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-intersection-observer ✅ Ready (Inspect) Visit Preview Jun 28, 2023 10:43am

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4c110ac:

Sandbox Source
useInView Configuration
InView render props Configuration
InView plain children Configuration

@thebuilder thebuilder merged commit a3f6487 into main Jun 28, 2023
7 checks passed
@thebuilder thebuilder deleted the fix/target-es2018 branch June 28, 2023 10:45
@alexsorokoletov
Copy link

Thank you for this, @thebuilder!

Wanted to share a bit of feedback - in our legacy app with webpack 3 (yeah, I know), the versions 9.5.x including 9.5.2 are still failing because of the spread operator, so we had to pin 9.4.x instead.

Upgrading webpack side of the build is not possible in our project at this moment (otherwise we would've done that).

Thanks for keeping this package up to date and resolving all the issues, and thank you for this OSS package!

@thebuilder
Copy link
Owner Author

Thank you for this, @thebuilder!

Wanted to share a bit of feedback - in our legacy app with webpack 3 (yeah, I know), the versions 9.5.x including 9.5.2 are still failing because of the spread operator, so we had to pin 9.4.x instead.

Upgrading webpack side of the build is not possible in our project at this moment (otherwise we would've done that).

Thanks for keeping this package up to date and resolving all the issues, and thank you for this OSS package!

You might be able to get around it, by explicitly including packages in your Webpack rules, so they'll be transformed by Babel.

@alexsorokoletov
Copy link

Thank you @thebuilder, that might be a valid path forward.
There are few layers of infrastructure above the webpack (main reason why it can't be migrated easily) and I wanted the information for anyone else with a similar lock in and a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package not working with webpack
2 participants