Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the manual chunks in vite config #55

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Updated the manual chunks in vite config #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e95a70
Updated the manualChunks function
Hudamabkhoot Oct 17, 2024
e30b32e
Fixed the button inside a button issue
Hudamabkhoot Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/components/NavBar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@ export function NavBar({ darkMode, toggleDarkMode }) {
darkMode ? 'Switch to light mode' : 'Switch to dark mode'
}
>
<button className=" rounded-full text-primary-pink hover:text-opacity-60">
{darkMode ? <Eclipse /> : <Sun />}
</button>
{darkMode ? <Eclipse /> : <Sun />}
</abbr>
</Button>
</div>
Expand Down Expand Up @@ -103,9 +101,7 @@ export function NavBar({ darkMode, toggleDarkMode }) {
darkMode ? 'Switch to light mode' : 'Switch to dark mode'
}
>
<button className="px-2 rounded-full text-primary-pink hover:text-opacity-60">
{darkMode ? <Eclipse /> : <Sun />}
</button>
{darkMode ? <Eclipse /> : <Sun />}
</abbr>
</Button>
{!!user ? (
Expand Down
10 changes: 5 additions & 5 deletions src/views/Login.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ function Login() {
className="fixed w-16 bottom-16 right-16 p-2 rounded-full text-primary-pink hover:text-primary-pink hover:text-opacity-60 font-semibold"
>
<abbr title={darkMode ? 'Switch to light mode' : 'Switch to dark mode'}>
<button
className={`${darkMode && 'dark'} rounded-full text-primary-pink hover:text-opacity-60`}
>
{darkMode ? <Eclipse /> : <Sun />}
</button>
{darkMode ? (
<Eclipse className="w-8 h-8" />
) : (
<Sun className="w-8 h-8" />
)}
</abbr>
</Button>
</div>
Expand Down
3 changes: 0 additions & 3 deletions vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ export default defineConfig(({ mode }) => ({
output: {
manualChunks: (id) => {
if (id.includes('node_modules')) {
if (id.includes('react')) {
return 'vendor__react';
}
if (id.includes('firebase')) {
return 'vendor__firebase';
}
Expand Down
Loading