Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced dropdown with radio buttons in AddItemForm. #50

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

Hudamabkhoot
Copy link
Collaborator

Description

Replaced the daysUntilNextPurchase dropdown with radio buttons in the AddItemForm modal for improved selection.

Related Issue

closes #46

Acceptance Criteria

  • Replace the dropdown with radio buttons on the AddItemForm modal.

Type of Changes

Enhancement

Updates

Before

Screen Shot 2024-10-03 at 2 05 25 PM

After

Screen Shot 2024-10-09 at 3 06 01 PM

Testing Steps / QA Criteria

  • Run git pull and checkout the branch hm-addItemForm-relocation-and-modifications.
  • Open the homepage by running npm start.
  • Navigate to the list page and click on the the "+" button to display the add modal.
  • You can see the new radio buttons which replaced the dropdown for daysUntilNextPurchase.

Copy link

github-actions bot commented Oct 9, 2024

Visit the preview URL for this PR (updated for commit adec26e):

https://tcl-79-smart-shopping-list--pr50-hm-add-item-radio-bu-v0vebude.web.app

(expires Wed, 16 Oct 2024 12:22:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

Copy link
Collaborator

@marshjaja marshjaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice!🤾🏾‍♀️

Copy link
Collaborator

@joriordan332 joriordan332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Well done

@Hudamabkhoot Hudamabkhoot merged commit e0db288 into feat/setup-tailwind-shadcn Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants