-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement design for list page #41
Conversation
Visit the preview URL for this PR (updated for commit b0f1226): https://tcl-79-smart-shopping-list--pr41-hm-list-layout-v11uvy5m.web.app (expires Sun, 13 Oct 2024 11:45:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks brilliant! Well done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing, Huda!
The list items are styled a bit different form the singleList items on the home page, maybe we should make them match in size and style? We can look into it as group once we put all PRs together :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hudamabkhoot amazing job!🚀
We need to alter the styling a bit, but I think it is good for now as we need to come together as a group and have all of our PR's inline. We can always adjust the styling later
Description
This pull request implements the design for the list page as specified in the Figma design. The main changes include:
Related Issue
Closes #34
Acceptance Criteria
Type of Changes
Enhancement
Updates
Before
After
Testing Steps / QA Criteria
git pull
andgit checkout hm-list-layout
npm start
.list
page.