Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement design for list page #41

Merged
merged 3 commits into from
Oct 6, 2024

Conversation

Hudamabkhoot
Copy link
Collaborator

@Hudamabkhoot Hudamabkhoot commented Oct 6, 2024

Description

This pull request implements the design for the list page as specified in the Figma design. The main changes include:

  • The layout of the list page has been updated to align with the Figma design.
  • The delete alert has been redesigned for improved clarity and user experience.

Related Issue

Closes #34

Acceptance Criteria

  • Add list name to list page to be able to know which list you're currently on.
  • Follow the figma design for the list page.

Type of Changes

Enhancement

Updates

Before

Screen Shot 2024-10-03 at 2 05 18 PM
Screen Shot 2024-10-06 at 7 44 47 AM

After

Screen Shot 2024-10-06 at 7 21 01 AM

Screen Shot 2024-10-06 at 7 21 13 AM

Testing Steps / QA Criteria

  • Do a git pull and git checkout hm-list-layout
  • Open the homepage by running npm start.
  • Navigate to the list page.
  • You can see the newly implemented design for the list page as specified in the Figma design.
  • Click the delete button to view the redesigned delete alert.

Copy link

github-actions bot commented Oct 6, 2024

Visit the preview URL for this PR (updated for commit b0f1226):

https://tcl-79-smart-shopping-list--pr41-hm-list-layout-v11uvy5m.web.app

(expires Sun, 13 Oct 2024 11:45:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

Copy link
Collaborator

@joriordan332 joriordan332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks brilliant! Well done :)

Copy link
Collaborator

@Wyna-7 Wyna-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, Huda!
The list items are styled a bit different form the singleList items on the home page, maybe we should make them match in size and style? We can look into it as group once we put all PRs together :)

Copy link
Collaborator

@marshjaja marshjaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hudamabkhoot amazing job!🚀
We need to alter the styling a bit, but I think it is good for now as we need to come together as a group and have all of our PR's inline. We can always adjust the styling later

@Hudamabkhoot Hudamabkhoot merged commit 1003bd0 into feat/setup-tailwind-shadcn Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants