Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate Add Item Functionality to Modal on List Page #37

Conversation

Hudamabkhoot
Copy link
Collaborator

Description

The add item functionality has been relocated to the list page, where it is now accessed via a modal triggered by clicking the "+" next to the search bar. This modal includes an option for specifying item quantity.

Related Issue

closes #33

Acceptance Criteria

  • Move the add item form to list page.
  • Prevent adding only numbers as item names, currently the form allows numbers to be item names and it will submit it as empty item list name.
  • Add item quantity.
  • Create a modal for add item to be displayed when the add button is clicked.
  • Clear input button should be removed following the design.

Type of Changes

Enhancement

Updates

Before

Screen Shot 2024-10-03 at 1 51 13 PM
Screen Shot 2024-10-03 at 2 05 54 PM

After

Screen Shot 2024-10-03 at 2 05 18 PM
Screen Shot 2024-10-03 at 2 05 25 PM

Testing Steps / QA Criteria

  • Do a git pull and git checkout hm-addItemForm-relocation-and-modifications
  • Open the homepage by running npm start.
  • Navigate to the list page.
  • The add item functionality should now be in a modal triggered by the "+" button next to the search bars with an option to specify item quantity.

Copy link

github-actions bot commented Oct 3, 2024

Visit the preview URL for this PR (updated for commit bbfd685):

https://tcl-79-smart-shopping-list--pr37-hm-additemform-reloc-69f6yhk4.web.app

(expires Fri, 11 Oct 2024 15:31:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

Copy link
Collaborator

@joriordan332 joriordan332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks brilliant! Well done

Copy link
Collaborator

@marshjaja marshjaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!👏🏾🚀
I just left some comments with some minor styling adjustments to aline with the design(sorry, as I wasn't sure--but you might have said you would address it in another issue?)

Screenshot 2024-10-04 at 14 55 41
Screenshot 2024-10-04 at 14 55 23

Screenshot 2024-10-04 at 14 56 12

src/components/ManageListForms/AddItemForm.jsx Outdated Show resolved Hide resolved
src/components/ui/dialog.jsx Outdated Show resolved Hide resolved
src/components/ui/dialog.jsx Outdated Show resolved Hide resolved
src/components/ui/dialog.jsx Show resolved Hide resolved
src/components/ui/input.jsx Outdated Show resolved Hide resolved
src/components/ui/select.jsx Outdated Show resolved Hide resolved
src/components/ui/select.jsx Outdated Show resolved Hide resolved
src/views/List.jsx Outdated Show resolved Hide resolved
@Hudamabkhoot
Copy link
Collaborator Author

Thank you @marshjaja i have applied all the adjustments you mentioned! Also yes the page styling will be on a different issue 👍

@Hudamabkhoot Hudamabkhoot merged commit db0d0af into feat/setup-tailwind-shadcn Oct 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants