-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate Add Item Functionality to Modal on List Page #37
Relocate Add Item Functionality to Modal on List Page #37
Conversation
Visit the preview URL for this PR (updated for commit bbfd685): https://tcl-79-smart-shopping-list--pr37-hm-additemform-reloc-69f6yhk4.web.app (expires Fri, 11 Oct 2024 15:31:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks brilliant! Well done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marshjaja i have applied all the adjustments you mentioned! Also yes the page styling will be on a different issue 👍 |
Description
The add item functionality has been relocated to the list page, where it is now accessed via a modal triggered by clicking the "+" next to the search bar. This modal includes an option for specifying item quantity.
Related Issue
closes #33
Acceptance Criteria
Type of Changes
Enhancement
Updates
Before
After
Testing Steps / QA Criteria
git pull
andgit checkout hm-addItemForm-relocation-and-modifications
npm start
.list
page.