Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share list component #22

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Share list component #22

merged 6 commits into from
Aug 30, 2024

Conversation

marshjaja
Copy link
Collaborator

@marshjaja marshjaja commented Aug 26, 2024

Description

With the change it allows the users to invite others to existing shopping lists so they can manage them with friends or family.

Related Issue

Close #6

Acceptance Criteria

  • The ManageList view shows a form that allows the user to enter an email to invite an existing user to a list, in addition to the form that allows them to add items to that list.
  • The input that accepts the email has a semantic label element associated with it.
  • The user can submit this form with both the mouse and the Enter key.
  • If the other user exists, the user is alerted that the list was shared.
  • If the other user does not exist, the user is shown an error message that explains the problem.

Type of Changes

Feature

Updates

Before

Screen Shot 2024-08-26 at 16 24 37

After

Screen Shot 2024-08-26 at 16 27 49

Screen Shot 2024-08-26 at 16 30 57
Screen Shot 2024-08-26 at 16 32 06

Testing Steps / QA Criteria

  • Do a git pull and git checkout hm-mm-shareList.
  • Open the homepage by running npm start.
  • Navigate to ManageList and you will find the ShareListForm where you can share your list with friends and family.
  • If the shopping list has been shared successfully a notification will appear telling the user this.
  • Incase of an error sharing the shopping list an error notification will appear describing the error, telling the user to try again.
  • To test the list sharing functionality, click on the specific list you would like to share on the Home page.

Copy link

Visit the preview URL for this PR (updated for commit 8eec0bc):

https://tcl-79-smart-shopping-list--pr22-hm-mm-sharelist-k5y4qkyt.web.app

(expires Mon, 02 Sep 2024 13:48:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

@Hudamabkhoot Hudamabkhoot changed the title Hm mm share list Share list component Aug 26, 2024
Copy link
Collaborator

@Wyna-7 Wyna-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I really like that you created separate components for the forms, it looks much cleaner 🙌

Copy link
Collaborator

@joriordan332 joriordan332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great guys well done! Just a very small side note I think the word 'problem' is missing on the pull request on the last acceptance criteria requirement

@Hudamabkhoot
Copy link
Collaborator

Looks great guys well done! Just a very small side note I think the word 'problem' is missing on the pull request on the last acceptance criteria requirement

Just added it. Thanks for pointing that out! 🙏

@Hudamabkhoot Hudamabkhoot merged commit 8422653 into main Aug 30, 2024
2 checks passed
@Hudamabkhoot Hudamabkhoot deleted the hm-mm-shareList branch August 30, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6. As a user, I want to be able to invite others to an existing shopping list
5 participants