-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share list component #22
Conversation
Visit the preview URL for this PR (updated for commit 8eec0bc): https://tcl-79-smart-shopping-list--pr22-hm-mm-sharelist-k5y4qkyt.web.app (expires Mon, 02 Sep 2024 13:48:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I really like that you created separate components for the forms, it looks much cleaner 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great guys well done! Just a very small side note I think the word 'problem' is missing on the pull request on the last acceptance criteria requirement
Just added it. Thanks for pointing that out! 🙏 |
Description
With the change it allows the users to invite others to existing shopping lists so they can manage them with friends or family.
Related Issue
Close #6
Acceptance Criteria
Type of Changes
Feature
Updates
Before
After
Testing Steps / QA Criteria
git pull
andgit checkout hm-mm-shareList
.ManageList
and you will find theShareListForm
where you can share your list with friends and family.Home
page.