-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SingleList to Home component and ListItem to List component #19
Conversation
Visit the preview URL for this PR (updated for commit c01b0d9): https://tcl-79-smart-shopping-list--pr19-mm-jo-rendered-list-8h730qgx.web.app (expires Fri, 23 Aug 2024 11:21:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
src/views/Home.jsx
Outdated
{/* {data.map((item) => ( | ||
<SingleList key={item.id} name={item.name} path={item.path} setListPath={setListPath} /> | ||
))} */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not needed, it is best to remove commented out code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work guys 🎉
Description
We rendered the shopping list the users have access to. And the name of the items on the list.
Related Issue
Issue #2
Acceptance Criteria
Type of Changes
Added The Shopping list feature.
Updates
Before
N/A
After
Items displayed
Testing Steps / QA Criteria
git pull
andgit checkout mm-jo-rendered-list
.npm start
.