Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SingleList to Home component and ListItem to List component #19

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

marshjaja
Copy link
Collaborator

Description

We rendered the shopping list the users have access to. And the name of the items on the list.

Related Issue

Issue #2

Acceptance Criteria

  • In Home.jsx, the SingleList component is used to render the name of each shopping list a user is subscribed to
  • In List.jsx, the ListItem component is used to render the name of each item

Type of Changes

Added The Shopping list feature.

Updates

Before

N/A

After

Items displayed

Testing Steps / QA Criteria

  • Do a git pull and git checkout mm-jo-rendered-list.
  • Open the homepage by running npm start.
  • Shopping will render on Home component and list items will show in List component.

Copy link

github-actions bot commented Aug 13, 2024

Visit the preview URL for this PR (updated for commit c01b0d9):

https://tcl-79-smart-shopping-list--pr19-mm-jo-rendered-list-8h730qgx.web.app

(expires Fri, 23 Aug 2024 11:21:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

Copy link
Collaborator

@Wyna-7 Wyna-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Comment on lines 11 to 13
{/* {data.map((item) => (
<SingleList key={item.id} name={item.name} path={item.path} setListPath={setListPath} />
))} */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not needed, it is best to remove commented out code :)

Copy link
Collaborator

@Hudamabkhoot Hudamabkhoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Copy link
Member

@hariscs hariscs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work guys 🎉

@marshjaja marshjaja merged commit 4d543cd into main Aug 17, 2024
2 checks passed
@joriordan332 joriordan332 deleted the mm-jo-rendered-list branch September 4, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants