Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user to specify tls version for backward compatibility #7654

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

allow user to specify tls version for backward compatibility #7654

wants to merge 3 commits into from

Conversation

pureiboi
Copy link
Contributor

@pureiboi pureiboi commented Aug 21, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

resolve issue #7624

  • expose flag to allow user to input tls version
  • when flag is not provided, default tls version to 1.3

Verification

sslscan is used to verify the tls version that was enabled

tls 1 3 tls 1 2

@pureiboi pureiboi force-pushed the feat/optional-tls-version branch 7 times, most recently from 26bb374 to f4b319a Compare August 21, 2024 16:47
harry671003
harry671003 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@harry671003 harry671003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

cmd/thanos/config.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harry671003 harry671003 harry671003 approved these changes

@yeya24 yeya24 Awaiting requested review from yeya24

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pureiboi @harry671003