Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruler UI: usage of alert.query-template inside Rules UI #7329

Merged
merged 7 commits into from
May 6, 2024
Merged

Ruler UI: usage of alert.query-template inside Rules UI #7329

merged 7 commits into from
May 6, 2024

Conversation

Vanshikav123
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

#7278

Verification

@Vanshikav123
rule
5673368 
Signed-off-by: Vanshikav123 <[email protected]>
Vanshikav123 and others added 4 commits May 3, 2024 00:22
@Vanshikav123
rule-changes
b408ffe 
Signed-off-by: Vanshikav123 <[email protected]>
@Vanshikav123
prettier
601ae26 
Signed-off-by: Vanshikav123 <[email protected]>
@Vanshikav123
Rebuild
c81d3e1 
Signed-off-by: Vanshikav123 <[email protected]>
@Vanshikav123
Merge branch 'thanos-io:main' into patch-rule_ui
a188fbd
saswatamcode
saswatamcode previously approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Generally good. Could you commit the UI changes after running make react-app?

@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 6, 2024
@Vanshikav123
Copy link
Contributor Author

Thanks! Generally good. Could you commit the UI changes after running make react-app?

done !

@saswatamcode saswatamcode enabled auto-merge (squash) May 6, 2024 08:14
@saswatamcode saswatamcode merged commit 7ce3f35 into thanos-io:main May 6, 2024
20 checks passed
@Vanshikav123 Vanshikav123 deleted the patch-rule_ui branch May 6, 2024 08:42
Nashluffy pushed a commit to Nashluffy/thanos that referenced this pull request May 14, 2024
@Vanshikav123 @Nashluffy
Ruler UI: usage of alert.query-template inside Rules UI (thanos-io#7329)
a5c2bcb 
* rule

Signed-off-by: Vanshikav123 <[email protected]>

* rule-changes

Signed-off-by: Vanshikav123 <[email protected]>

* prettier

Signed-off-by: Vanshikav123 <[email protected]>

* Rebuild

Signed-off-by: Vanshikav123 <[email protected]>

* changes after make react-app

Signed-off-by: Vanshikav123 <[email protected]>

---------

Signed-off-by: Vanshikav123 <[email protected]>
Signed-off-by: mluffman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vanshikav123 @saswatamcode