fetcher: sanity check metas for common corruptions #7282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Mark metas with incomplete files as corrupted. Once shipper uploads the meta, the block is considered complete. This should make it possible to use the "Files" field in meta for a cheap check if the block is valid if its already in object storage. Neither storage-gw nor compactor can handle incomplete blocks, so this should fix a couple runtime issues; produce metrics and automatically clean up this issue.
Added a flag to disable cleanup of partially uploaded blocks that defaults to true.
Verification
Added unittests
Should solve #6328