Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execution: add count_values aggregation #441

Merged
merged 1 commit into from
Jun 7, 2024
Merged

execution: add count_values aggregation #441

merged 1 commit into from
Jun 7, 2024

Conversation

MichaHoffmann
Copy link
Contributor

@MichaHoffmann MichaHoffmann commented Mar 31, 2024 •
edited

Implementation feels fairly hacky but passes acceptance tests and fuzzing! I plan to clean it up later but its a good start.

@MichaHoffmann MichaHoffmann force-pushed the mhoffm-count-values branch 4 times, most recently from c1dd8ba to 73747e3 Compare March 31, 2024 19:07
@MichaHoffmann MichaHoffmann marked this pull request as ready for review June 2, 2024 14:26
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-count-values branch 4 times, most recently from 5005532 to b4f465c Compare June 2, 2024 14:33
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-count-values branch 4 times, most recently from 1ede4ae to 4e3b8c8 Compare June 2, 2024 14:59
@MichaHoffmann
Copy link
Contributor Author

Not that it is super important but the implementation does benchmark ok:

$ go test . -run none -bench BenchmarkInstantQuery/count_values -v
goos: linux
goarch: amd64
pkg: github.com/thanos-io/promql-engine/engine
cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
BenchmarkInstantQuery
BenchmarkInstantQuery/count_values
BenchmarkInstantQuery/count_values/old_engine
BenchmarkInstantQuery/count_values/old_engine-8         	      86	  13438595 ns/op	 3144286 B/op	   30155 allocs/op
BenchmarkInstantQuery/count_values/new_engine
BenchmarkInstantQuery/count_values/new_engine-8         	     136	   8212708 ns/op	 6139048 B/op	   34614 allocs/op
PASS
ok  	github.com/thanos-io/promql-engine/engine	6.812s

@MichaHoffmann MichaHoffmann merged commit 477ba55 into main Jun 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetkovski fpetkovski fpetkovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaHoffmann @fpetkovski