Add Azure Event Hubs Emulator container to Azure module #9665
Conversation
nagyesta
force-pushed
the
feature/add-azure-eventhubs-container
branch
2 times, most recently
from
41ee74d to
4c40dfd
Compare
nagyesta
force-pushed
the
feature/add-azure-eventhubs-container
branch
5 times, most recently
from
148c7fc to
8c821d8
Compare
- Add Azure Eventhubs Emulator container - Implement new test case - Update Azure documentation Signed-off-by: Esta Nagy <[email protected]>
nagyesta
force-pushed
the
feature/add-azure-eventhubs-container
branch
from
8c821d8 to
fa3e337
Compare
modules/azure/src/main/java/org/testcontainers/azure/AzureEventhubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
| * @param config The file containing the broker configuration | ||
| * @return this | ||
| */ | ||
| public AzureEventhubsEmulatorContainer withConfig(final MountableFile config) { |
There was a problem hiding this comment.
| public AzureEventhubsEmulatorContainer withConfig(final MountableFile config) { | |
| public AzureEventhubsEmulatorContainer withConfig(final Transferable config) { |
There was a problem hiding this comment.
Should I update the Azurite config too similarly? It feels wrong to use two different approaches...
There was a problem hiding this comment.
Using transferable for the config file makes sense because the json file can be built programmatically. I do not expect the same for the certificates. WDYT?
There was a problem hiding this comment.
To be honest I don't see the big difference but this might be just because I am not that familiar with these two types and the exact intent behind them (hopefully I will learn now).
We can generate (or download from a secure place) a Java KeyStore without ever writing it to file, also if you want to generate a configuration json, it is a small step to write it to a temp file and then simply create a MountableFile with it. Or is the difference more nuanced?
modules/azure/src/main/java/org/testcontainers/azure/AzureEventhubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzureEventhubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzureEventhubsEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
- Fix license acceptance - Use Transferable - Remove unnecessary code from tests Signed-off-by: Esta Nagy <[email protected]>
- Fix Typo in the container's name - Require AzuriteContainer as dependency - Add Kafka Event Hubs test - Add Kafka option to Azure documentation Signed-off-by: Esta Nagy <[email protected]>
- Fix typos Signed-off-by: Esta Nagy <[email protected]>
- Fix test method name Signed-off-by: Esta Nagy <[email protected]>
nagyesta
changed the title
- Polish Signed-off-by: Esta Nagy <[email protected]>
Must be merged after: #9661
Relates to: #9607 (comment)