Iss84 SHOW - Allow infinite looping of sequences #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronAmbright
commented
Apr 24, 2019
ByronAmbright
commented
- Add checkbox to allow for infinite looping of shows
- Add functionality to infinite loop sequences
- Fix element length bug in case sequence does not have audio file.
theeldestelder
requested changes
Apr 25, 2019
There was a problem hiding this comment.
This works in that it repeats an element, but those elements take longer and longer every iteration. In the sequence I'm testing, the lights are on for half the time and off the other half. Each half increases in length. The timeouts fire every 5 seconds like they're supposed to, but the lights do not change that often. I'm not sure what the fix is, but this needs to be fixed.
app/html/show.html
Outdated
| @@ -23,6 +23,8 @@ | |||
| <button id='addElement'>Add element</button> | |||
| <br><br> | |||
| <button id='runShow' value='notPlaying'>Play</button> | |||
| <span>Repeat?</span> | |||
There was a problem hiding this comment.
Make this more descriptive. Repeat what? Something like Loop show continuously?.
app/js/sendDMX.js
Outdated
| playShowInSequence(i); | ||
| } | ||
| if (repeat.checked && canPlay) { | ||
| const elementsLength = elements.map(x => x.elementLength); |
There was a problem hiding this comment.
Should we be using x.getElementLength() here?
* Add checkbox to allow for infinite looping of shows * Add functionality to infinite loop sequences * Fix element length bug in case that sequence does not have audio file. * Change sendDMX.js functions into a module for more flexible use. * Rename sendDMX.js to ShowRunner.js to accurately describe functions.
ByronAmbright
force-pushed
the
Iss84_Allow_Infinite_Looping
branch
from
679b9f9
to
b6b23ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.