Iss93 #126
Open
Iss93 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re is no internet there will be an alert to notify the user.
theeldestelder
requested changes
Nov 11, 2019
| @@ -85,6 +85,9 @@ function getUrl() { | |||
| // 4. Write the patch to patch.json | |||
| // 5. Apply the patch to the entire show | |||
| function patchShow() { | |||
| if (!navigator.onLine) { | |||
There was a problem hiding this comment.
I would move this into the next block of code directly under the
label.innerText = 'Fetching Google Sheet...'; line because this is part of that whole process. That way, errors thrown here should be caught by the promise.
I would also include a return; at the end of this if statement because we don't want to try and execute a request over the Internet when we know there's no Internet go send a request over
There was a problem hiding this comment.
You'll probably need to delete your local branch and checkout to a branch of the same name because @ByronAmbright force pushed to this branch to resolve some lingering commit issues. Let us know if you need help figuring out how to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in the patchShow function to check for internet. If there is no internet the user will be notified.