Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: John Stilley <[email protected]>
  • Loading branch information
drewj-tp and john-science committed Sep 20, 2024
1 parent 52f7d50 commit f893079
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 3 additions & 3 deletions armi/reactor/tests/test_blocks.py
Original file line number Diff line number Diff line change
Expand Up @@ -1739,13 +1739,13 @@ class BlockRotateTests(unittest.TestCase):
"""Tests for the ability for a block to be rotated."""

BOUNDARY_PARAMS = [
"pointsCornerDpa",
"cornerFastFlux",
"pointsCornerFastFluxFr",
"pointsCornerDpa",
"pointsCornerDpaRate",
"pointsEdgeFastFluxFr",
"pointsCornerFastFluxFr",
"pointsEdgeDpa",
"pointsEdgeDpaRate",
"pointsEdgeFastFluxFr",
]
BOUNDARY_DATA = np.arange(6, dtype=float) * 10

Expand Down
4 changes: 1 addition & 3 deletions doc/release/0.4.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ New Features
#. ARMI now supports Python 3.12. (`PR#1813 <https://github.com/terrapower/armi/pull/1813>`_)
#. Removing the ``tabulate`` dependency by ingesting it to ``armi.utils.tabulate``. (`PR#1811 <https://github.com/terrapower/armi/pull/1811>`_)
#. Adding ``--skip-inspection`` flag to ``CompareCases`` CLI. (`PR#1842 <https://github.com/terrapower/armi/pull/1842>`_)
#. Provide utilities for determining location of a rotated object in a hexagonal lattice:
:func:`armi.utils.hexagon.getIndexOfRotatedCell`
(`PR#1846 <https://github.com/terrapower/armi/1846`)
#. Provide utilities for determining location of a rotated object in a hexagonal lattice: ``getIndexOfRotatedCell``. (`PR#1846 <https://github.com/terrapower/armi/1846`_)
#. Allow merging a component with zero area into another component (`PR#1858 <https://github.com/terrapower/armi/pull/1858>`_)
#. ``HexBlock.rotate`` will rotate additionally rotate ``HexBlock`` parameters with ``ParamLocation.CHILDREN``.
(`PR#1877 <https://github.com/terrapower/armi/pull/1877>`_)
Expand Down

0 comments on commit f893079

Please sign in to comment.