Cleaning out defunct to do comments (#1879)

armi/bookkeeping/db/tests/test_comparedb3.py

@@ -135,7 +135,7 @@ def test_compareDatabaseSim(self):
  inputFileName="smallestTestReactor/armiRunSmallest.yaml",
  )
 
- # create two DBs, identical but for file names
+ # create two DBs, identical but for file names and cycle lengths
  dbs = []
  for lenCycle in range(1, 3):
  # build some test data

armi/bookkeeping/db/tests/test_database3.py

@@ -315,7 +315,6 @@ def test_auxData(self):
  with self.assertRaises(KeyError):
  self.db.genAuxiliaryData((-1, -1))
 
- # TODO: This should be expanded.
  def test_replaceNones(self):
  """Super basic test that we handle Nones correctly in database read/writes."""
  data3 = np.array([[1, 2, 3], [4, 5, 6], [7, 8, 9]])

armi/reactor/blueprints/tests/test_blockBlueprints.py

@@ -332,7 +332,6 @@ def test_explicitFlags(self):
  self.assertTrue(a1.hasFlags(Flags.FUEL, exact=True))
  self.assertTrue(a2.hasFlags(Flags.FUEL | Flags.TEST, exact=True))
 
- # TODO: This test passes, but shouldn't.
  def test_densityConsistentWithComponentConstructor(self):
  a1 = self.blueprints.assemDesigns.bySpecifier["IC"].construct(
  self.cs, self.blueprints

armi/reactor/blueprints/tests/test_blueprints.py

@@ -35,19 +35,10 @@
 
 
 class TestBlueprints(unittest.TestCase):
- """Test that the basic functionality of faithfully receiving user input to construct
- ARMI data model objects works as expected.
+ """Test that the basic functionality of faithfully receiving user input to construct ARMI data
+ model objects works as expected.
 
- Values are hopefully not hardcoded in here, just sanity checks that nothing messed
- up as this is code has VERY high incidental coverage from other tests.
-
- NOTE: as it stands it seems a little hard to test more granularity with the
- blueprints file as each initialization is intended to be a complete load from the
- input file, and each load also
- makes calls out to the reactor for some assembly initialization steps.
-
- TODO: see the above note, and try to test blueprints on a wider range of input
- files, touching on each failure case.
+ Try to ensure you test for ideas and not exact matches here, to make the tests more robust.
  """
 
  @classmethod

armi/reactor/composites.py

@@ -504,7 +504,6 @@ def copyParamsFrom(self, other):
  ----------
  other : ArmiObject
  The object to copy params from
-
  """
  self.p = other.p.__class__()
  for p, val in other.p.items():

armi/reactor/tests/test_blocks.py

@@ -70,8 +70,6 @@ def buildSimpleFuelBlock():
  b.add(coolant)
  b.add(intercoolant)
 
- b.getVolumeFractions() # TODO: remove, should be no-op when removed self.cached
-
  return b
 
 
@@ -232,8 +230,6 @@ def loadTestBlock(cold=True):
  block.add(duct)
  block.add(interSodium)
 
- block.getVolumeFractions() # TODO: remove, should be no-op when removed self.cached
-
  block.setHeight(16.0)
 
  block.autoCreateSpatialGrids()