more CS adjustments

terrafrost · Sep 25, 2023 · d437385 · d437385
1 parent cb3aff1
commit d437385
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 6 deletions.
diff --git a/phpseclib/Crypt/DH.php b/phpseclib/Crypt/DH.php
@@ -243,7 +243,6 @@ public static function createParameters(...$args): Parameters
      * $length is in bits
      *
      * @param int $length optional
-     * @return DH\PrivateKey
      */
     public static function createKey(Parameters $params, int $length = 0): PrivateKey
     {

diff --git a/phpseclib/Crypt/DSA.php b/phpseclib/Crypt/DSA.php
@@ -180,7 +180,6 @@ public static function createParameters(int $L = 2048, int $N = 224)
      * Returns the private key, from which the publickey can be extracted
      *
      * @param int[] ...$args
-     * @return DSA\PrivateKey
      */
     public static function createKey(...$args): PrivateKey
     {

diff --git a/phpseclib/Math/BigInteger.php b/phpseclib/Math/BigInteger.php
@@ -31,8 +31,8 @@
 
 use phpseclib3\Exception\BadConfigurationException;
 use phpseclib3\Exception\InvalidArgumentException;
+use phpseclib3\Exception\UnexpectedValueException;
 use phpseclib3\Math\BigInteger\Engines\Engine;
-use UnexpectedValueException;
 
 /**
  * Pure-PHP arbitrary precision integer arithmetic library. Supports base-2, base-10, base-16, and base-256

diff --git a/phpseclib/bootstrap.php b/phpseclib/bootstrap.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * Bootstrapping File for phpseclib
  *

diff --git a/tests/Functional/Net/SFTPUserStoryTest.php b/tests/Functional/Net/SFTPUserStoryTest.php
@@ -816,5 +816,7 @@ public function testCallableGetWithLength($sftp)
         $sftp->get('test.txt', function ($data) {
         }, 0, 1);
         $this->assertTrue(true);
+
+        return $sftp;
     }
 }
diff --git a/tests/Unit/File/X509/X509Test.php b/tests/Unit/File/X509/X509Test.php
@@ -1293,7 +1293,7 @@ public function testMalformedExt(): void
         $this->assertIsArray($r);
     }
 
-    public function testWildcardCert()
+    public function testWildcardCert(): void
     {
         $cert = '-----BEGIN CERTIFICATE-----
 MIIKqDCCCZCgAwIBAgIQAZ3dCTUFVNcaZ4TM/m6DFTANBgkqhkiG9w0BAQsFADBY
@@ -1365,7 +1365,7 @@ public function testWildcardCert()
     /**
      * @group github1943
      */
-    public function testWeirdCharsCert()
+    public function testWeirdCharsCert(): void
     {
         $cert = '-----BEGIN CERTIFICATE-----
 MIIDtTCCAp2gAwIBAgICECEwDQYJKoZIhvcNAQELBQAwYzELMAkGA1UEBhMCVVMx

diff --git a/tests/Unit/Math/PrimeFieldTest.php b/tests/Unit/Math/PrimeFieldTest.php
@@ -26,7 +26,7 @@ public function testPrimeFieldWithCompositeNumbers(): void
     /**
      * @group github1929
      */
-    public function testGarbageCollectedToBytes()
+    public function testGarbageCollectedToBytes(): void
     {
         $blob = base64_decode('BFgsTFQeqKr0toyURbtT43INMDS7FTHjz3yn3MR1/Yv/pb2b9ZCYNQ/Tafe5hQpEJ4TpZOKfikP/hWZvFL8QCPgqbIGqw/KTfA==');
         $public = "\0" . substr($blob, 0, 49);