X509: algorithmidentifier parameters could get incorrectly set

terrafrost · Nov 29, 2024 · 5d69be1 · 5d69be1
1 parent ad709d8
commit 5d69be1
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/phpseclib/File/X509.php b/phpseclib/File/X509.php
@@ -519,11 +519,6 @@ public function saveX509(array $cert, $format = self::FORMAT_PEM)
                 );
         }
 
-        if ($algorithm == 'rsaEncryption') {
-            $cert['signatureAlgorithm']['parameters'] = null;
-            $cert['tbsCertificate']['signature']['parameters'] = null;
-        }
-
         $filters = [];
         $type_utf8_string = ['type' => ASN1::TYPE_UTF8_STRING];
         $filters['tbsCertificate']['signature']['parameters'] = $type_utf8_string;
@@ -2994,7 +2989,10 @@ private static function identifySignatureAlgorithm(PrivateKey $key)
                 case 'sha256':
                 case 'sha384':
                 case 'sha512':
-                    return ['algorithm' => $key->getHash() . 'WithRSAEncryption'];
+                    return [
+                        'algorithm' => $key->getHash() . 'WithRSAEncryption',
+                        'parameters' => null
+                    ];
             }
             throw new UnsupportedAlgorithmException('The only supported hash algorithms for RSA are: md2, md5, sha1, sha224, sha256, sha384, sha512');
         }