Skip to content

Commit

Permalink
fix!: remove apphub_service_uri from output of simple_bucket (#372)
Browse files Browse the repository at this point in the history
  • Loading branch information
q2w authored Dec 10, 2024
1 parent 480dedf commit 7459e41
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 15 deletions.
14 changes: 14 additions & 0 deletions docs/upgrading_to_v9.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Upgrading to v9.0

The v9.0 release contains backwards-incompatible changes.

## Replace uses of apphub_service_uri

This release removes apphub_service_uri output. You can replace use of `apphub_service_uri` by forming the desired output as below,

```
{
service_uri = "//storage.googleapis.com/${module.simple_bucket.name}"
service_id = substr(module.simple_bucket.name, 0, 63)
}
```
1 change: 0 additions & 1 deletion modules/simple_bucket/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ Functional examples are included in the

| Name | Description |
|------|-------------|
| apphub\_service\_uri | URI in CAIS style to be used by Apphub. |
| bucket | The created storage bucket |
| internal\_kms\_configuration | The intenal KMS Resource. |
| name | Bucket name. |
Expand Down
6 changes: 0 additions & 6 deletions modules/simple_bucket/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,6 @@ spec:
})
defaultValue: {}
outputs:
- name: apphub_service_uri
description: URI in CAIS style to be used by Apphub.
type:
- object
- service_id: string
service_uri: string
- name: bucket
description: The created storage bucket
type:
Expand Down
8 changes: 0 additions & 8 deletions modules/simple_bucket/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,3 @@ output "internal_kms_configuration" {
description = "The intenal KMS Resource."
value = var.internal_encryption_config.create_encryption_key ? module.encryption_key[0] : null
}

output "apphub_service_uri" {
value = {
service_uri = "//storage.googleapis.com/${google_storage_bucket.bucket.name}"
service_id = substr(google_storage_bucket.bucket.name, 0, 63)
}
description = "URI in CAIS style to be used by Apphub."
}

0 comments on commit 7459e41

Please sign in to comment.