Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sabnzbd: disable auto-updates #20244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sabnzbd: disable auto-updates #20244

wants to merge 1 commit into from

Conversation

tqfx
Copy link
Contributor

@tqfx tqfx commented May 17, 2024

Close #20243

@twaik
Copy link
Member

twaik commented May 17, 2024

Downgrading a package will not work, aptly will not let you upload the package. You should increase epoch value.
https://github.com/termux/termux-packages/blob/master/CONTRIBUTING.md#downgrading-the-package-or-changing-versioning-scheme

@tqfx
Copy link
Contributor Author

tqfx commented May 17, 2024

How about bumping sabnzbd to 4.3.2RC1 and disabling auto-updates?

@macearl
Copy link

macearl commented May 18, 2024

I haven't yet noticed any problems with the RC. Going by previous releases it should also only be a week or two before 4.3.2 will be released.

@twaik
Copy link
Member

twaik commented May 18, 2024

We prefer to package stable versions.

@tqfx
Copy link
Contributor Author

tqfx commented May 18, 2024

So wait for sabnzbd 4.3.2 to be released?

@twaik
Copy link
Member

twaik commented May 18, 2024

I think so.

@tqfx tqfx changed the title sabnzbd: disable auto updates python-sabyenc3: disable auto updates May 18, 2024
@tqfx tqfx marked this pull request as ready for review May 18, 2024 11:48
@tqfx tqfx marked this pull request as draft May 20, 2024 01:38
@tqfx tqfx marked this pull request as ready for review May 20, 2024 02:07
@tqfx tqfx changed the title python-sabyenc3: disable auto updates sabnzbd: downgrade python-sabyenc3 to 8.1.0, disable auto updates May 20, 2024
@TomJo2000
Copy link
Member

TomJo2000 commented May 30, 2024

Oh nvm this seems to have solved itself with 2e5aa4d
So I guess this PR can be closed?

@TomJo2000 TomJo2000 self-requested a review May 30, 2024 13:20
@tqfx tqfx closed this May 30, 2024
@tqfx tqfx deleted the sabnzbd branch May 30, 2024 13:33
@macearl
Copy link

macearl commented May 30, 2024

As long as auto updates for this package and sabnzbd are enabled problems like this will likely reappear in the future.

sabnzbd=4.3.2 still needs sabctools/python-sabyenc3=8.2.0 ( https://github.com/sabnzbd/sabnzbd/blob/4.3.2/sabnzbd/constants.py#L52 ) but python-sabyenc3 was already updated to 8.2.3.

I haven't tried updating sabnzbd again this time to validate this but seeing as it's been this way every time i tried it in the past i think it's safe to skip the validation this time.

@tqfx
Copy link
Contributor Author

tqfx commented May 30, 2024

sabnzbd verifies that the version matches at least the minor version https://github.com/sabnzbd/sabnzbd/blob/4.3.2/sabnzbd/decoder.py#L46

@macearl
Copy link

macearl commented May 30, 2024

Oh, you're right, but that still leaves the possibility of a mismatch in the future once the major version does not match anymore?

Wouldn't just cherrypicking the removal of TERMUX_PKG_AUTO_UPDATE=true from this PR stop this from happening? But then, of course, every update would need to be manually commited.

@tqfx tqfx restored the sabnzbd branch May 30, 2024 15:38
@tqfx tqfx reopened this May 30, 2024
@tqfx tqfx changed the title sabnzbd: downgrade python-sabyenc3 to 8.1.0, disable auto updates sabnzbd: disable auto-updates May 30, 2024
@TomJo2000
Copy link
Member

Oh, you're right, but that still leaves the possibility of a mismatch in the future once the major version does not match anymore?

Wouldn't just cherrypicking the removal of TERMUX_PKG_AUTO_UPDATE=true from this PR stop this from happening? But then, of course, every update would need to be manually commited.

What we can do is overwrite the auto-update function to ensure the minor version stays matching.
I can take a look at that in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sabnzbd=4.3.1-2 fails to install due to python-sabyenc3=8.2.0 and cffi Android NDK incompatibility
4 participants