Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jq-lsp: init at 0.1.3 #19727

Merged
merged 1 commit into from
May 30, 2024
Merged

jq-lsp: init at 0.1.3 #19727

merged 1 commit into from
May 30, 2024

Conversation

Freed-Wu
Copy link
Contributor

Fix #15970

2096779623
2096779623 requested changes Apr 20, 2024
View reviewed changes
Copy link
Member

@2096779623 2096779623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not put the build and installation steps together, separate them using termux_step_make and termux_step_make_install.

@Freed-Wu
Copy link
Contributor Author

Fixed.

@TomJo2000 TomJo2000 requested a review from 2096779623 May 30, 2024 13:01
@TomJo2000
Copy link
Member

Good to merge for now, I'll fix the autoupdate in a bit.

@TomJo2000 TomJo2000 merged commit 3a8a557 into termux:master May 30, 2024
6 of 7 checks passed
@wader
Copy link

wader commented May 30, 2024

@Freed-Wu Thanks for packaging jq-lsp!

@Freed-Wu Freed-Wu deleted the jq-lsp branch May 30, 2024 13:39
Freed-Wu added a commit to Freed-Wu/termux-packages that referenced this pull request Jun 6, 2024
@Freed-Wu
addpkg(main/jq-lsp): 0.1.3 (termux#19727)
8d672f4 
Fix termux#15970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finagolfin finagolfin Awaiting requested review from finagolfin finagolfin is a code owner

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

@2096779623 2096779623 Awaiting requested review from 2096779623

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package]: jq-lsp
4 participants
@Freed-Wu @TomJo2000 @wader @2096779623