Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: Set timestamp and owner for all files in apt package #19686

Merged
merged 2 commits into from
May 22, 2024
Merged

scripts: Set timestamp and owner for all files in apt package #19686

merged 2 commits into from
May 22, 2024

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Apr 6, 2024 •
edited by Grimler91

This makes apt packages somewhat reproducible. The tar options were copied from https://salsa.debian.org/dpkg-team/dpkg/-/blob/1.22.6/scripts/Dpkg/Source/Archive.pm?ref_type=tags#L70-L73

The changes are similar as 09127c897042758b0b527c7968cb613eaebd6e3c commit.

@Biswa96 Biswa96 requested a review from Grimler91 as a code owner April 6, 2024 07:17
@Biswa96
Copy link
Contributor Author

Biswa96 commented Apr 6, 2024

I have tested this change with libaom packages. The following SHA256 from my system matches with CI artifacts exactly. SOURCE_DATE_EPOCH=1712385579

$ sha256sum output/*aom*
bdd1855b7be8467f4f06a5b7067ef5e2ef6234b6b556bd4ef7251abc3afe9416  output/aom-tools_3.7.0-1_aarch64.deb
75148bcd6ba39e1700c30ddcb5e5eb64ab1c6c9ebfeb0650702b9e9440a9af52  output/libaom_3.7.0-1_aarch64.deb
e4db039c6bbe57eaae9345caaf771b9e613cdcb1c7a8ec1990b40cdbefa0a3c1  output/libaom-static_3.7.0-1_aarch64.deb

@Grimler91
Copy link
Member

Nice!

Will do some tests as well

@twaik
Copy link
Member

twaik commented Apr 24, 2024

So that one can be merged, right?

TomJo2000
TomJo2000 approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this hasn't been merged yet, looks all good to me.
If there's no more comments I'll merge this tomorrow.

@TomJo2000 TomJo2000 merged commit 22a5438 into termux:master May 22, 2024
@Biswa96 Biswa96 deleted the repro branch May 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truboxl truboxl truboxl approved these changes

@TomJo2000 TomJo2000 TomJo2000 approved these changes

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Biswa96 @Grimler91 @twaik @truboxl @TomJo2000