Embedding Projector: fix knn for non-normalized vectors #6293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Fixes #6271
Fixes #5547
Technical description of changes
the reason is that knn expects normalized vectors for cosine distance (cosDistNorm) rather than arbitrary vectors.
Screenshots of UI changes
N/A
Detailed steps to verify changes work correctly (as executed by you)
Alternative repo:
Alternate designs / implementations considered