Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quick multi-select operation with host and processes filters #907

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable quick multi-select operation with host and processes filters #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 42 additions & 4 deletions plugin/trace_viewer/tf_trace_viewer/tf-trace-viewer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,16 +362,34 @@
background-image: unset;
background-color: rgb(243, 245, 247);
}
.process-track-header:hover{
cursor: pointer;
}
/* Move the triangle button from process-track-name to process-track-header to enable track name selection */
.process-track-base.expanded .process-track-header:before {
content: '\25BE'; /* Down triangle */
cursor: pointer;
}
.process-track-header:before {
content: '\25B8'; /* Right triangle */
padding: 0 5px;
cursor: pointer;
}
.process-track-base.expanded .process-track-header {
background-image: unset;
background-color: #cbd6e3;
}
.process-track-base.expanded .process-track-name:before {
cursor: pointer;
.process-track-name {
user-select: text;
flex-grow: unset;
padding-right: 36px;
cursor: text;
}
.process-track-name:before {
padding: 0 5px;
cursor: pointer;
display: none;
}
.process-track-base.expanded .process-track-name:before {
display: none;
}
#arrow.tr-ui-b-heading {
cursor: pointer;
Expand All @@ -380,6 +398,8 @@
color: #424242;
cursor: pointer;
border: none;
position: absolute;
right: 5px;
}
.process-track-close:hover {
outline: none;
Expand Down Expand Up @@ -1099,6 +1119,23 @@
}
},

_updateProcessHeader: function() {
const processNameEls = document.getElementsByClassName('process-track-name');

// Overwrite the click event with noop and prevent event propogatin to enable text selection.
for (let i = 0; i < processNameEls.length; ++i) {
processNameEls[i].addEventListener('mousedown', (e) => {
e.stopPropagation();
});
processNameEls[i].addEventListener('click', (e) => {
e.stopPropagation();
});
processNameEls[i].addEventListener('mousemove', (e) => {
e.stopPropagation();
});
}
},

// Overwrite and fine tune the inherited catapult/tracing UI
_adjustUI: function() {
// 1. Adjust styles of the leftControl and its children
Expand Down Expand Up @@ -1196,6 +1233,7 @@
this._insertRenderCompleteSignal();
}
this._updateModeSelectorBehavior();
this._updateProcessHeader();
},

_loadNonStreamingTrace: async function() {
Expand Down