Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the command to install pip install tensorflow[and-cuda] is not working. The pip install 'tensorflow[and-cuda]' works #2308

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

joaomh
Copy link
Contributor

@joaomh joaomh commented May 15, 2024

the command to install pip install tensorflow[and-cuda] is not working. The pip install 'tensorflow[and-cuda]' works.

the command to install pip install tensorflow[and-cuda] is not working. The pip install 'tensorflow[and-cuda]' works.
Copy link

google-cla bot commented May 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link
Contributor

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use "add file"/"update file"/"fix file"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.

Approving this for now, thank you for the PR

The commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.

For how to write good quality git commit messages, please consult https://cbea.ms/git-commit/

@joaomh joaomh changed the title Update pip.md the command to install pip install tensorflow[and-cuda] is not working. The pip install 'tensorflow[and-cuda]' works May 27, 2024
@8bitmp3
Copy link
Contributor

8bitmp3 commented May 29, 2024

@joaomh Thank you. Please review the CLA situation (link below under cla/google or here https://github.com/tensorflow/docs/pull/2308/checks?check_run_id=25015627833).

@8bitmp3 8bitmp3 added the cla: no CLA has not been signed label Oct 11, 2024
@joaomh
Copy link
Contributor Author

joaomh commented Nov 11, 2024

I already have a CLA, but when I try to rescan my contribution, I keep getting a '400 error. Can some of you rerun for me? @haifeng-jin @mihaimaruseac

@google-cla google-cla bot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Nov 12, 2024
@mihaimaruseac
Copy link
Contributor

Should be fixed now

@8bitmp3 8bitmp3 added the ready to pull Start merge process label Nov 19, 2024
@8bitmp3
Copy link
Contributor

8bitmp3 commented Nov 19, 2024

thank you all

@copybara-service copybara-service bot merged commit b6696db into tensorflow:master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants