-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DTensor docs, lint notebooks #2276
Conversation
PreviewPreview and run these notebook edits with Google Colab:
Format and styleUse the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:$ python3 -m pip install -U --user git+https://github.com/tensorflow/docsIf commits are added to the pull request, synchronize your local branch: git pull origin update-dtensor
|
@@ -98,7 +100,7 @@ | |||
}, | |||
"outputs": [], | |||
"source": [ | |||
"!pip install --quiet --upgrade --pre tensorflow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarkDaoust removed the "--pre"
@@ -76,7 +76,7 @@ | |||
"\n", | |||
"By decoupling the application from sharding directives, DTensor enables running the same application on a single device, multiple devices, or even multiple clients, while preserving its global semantics.\n", | |||
"\n", | |||
"This guide introduces DTensor concepts for distributed computing, and how DTensor integrates with TensorFlow. To see a demo of using DTensor in model training, see [Distributed training with DTensor](https://www.tensorflow.org/tutorials/distribute/dtensor_ml_tutorial) tutorial." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarkDaoust introduced a relative link
@@ -107,9 +109,9 @@ | |||
"id": "O3pG29uZIWYO" | |||
}, | |||
"source": [ | |||
"Once installed, import `tensorflow` and `tf.experimental.dtensor`. Then configure TensorFlow to use 6 virtual CPUs.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarkDaoust full API with tf.experimental
is mentioned in the beginning of the section, so shortened this.
Later, "vCPU" -> "virtual CPU"
site/en/guide/dtensor_overview.ipynb
Outdated
@@ -98,7 +100,7 @@ | |||
}, | |||
"outputs": [], | |||
"source": [ | |||
"!pip install --quiet --upgrade --pre tensorflow" | |||
"!pip install --quiet --upgrade tensorflow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't bother with installing tensorflow. It was only here because the pre-installed version was insufficient.
@@ -99,7 +102,7 @@ | |||
}, | |||
"outputs": [], | |||
"source": [ | |||
"!pip install --quiet --upgrade --pre tensorflow tensorflow-datasets" | |||
"!pip install --quiet --upgrade tensorflow tensorflow-datasets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove this, and lint the notebooks
No description provided.