Hide internal errors from responses to client #5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
May 13, 2024
alexshtin
reviewed
May 14, 2024
yycptt
reviewed
May 14, 2024
yiminc
reviewed
May 15, 2024
yycptt
reviewed
May 16, 2024
dnr
reviewed
May 16, 2024
ychebotarev
force-pushed
the
y_replace_fe_errors
branch
from
f0ca069
to
015adff
Compare
yiminc
requested changes
May 17, 2024
alexshtin
reviewed
May 17, 2024
alexshtin
reviewed
May 17, 2024
dnr
reviewed
May 18, 2024
ychebotarev
force-pushed
the
y_replace_fe_errors
branch
from
ae71b98
to
f80cf96
Compare
Co-authored-by: Yichao Yang <[email protected]>
ychebotarev
force-pushed
the
y_replace_fe_errors
branch
from
f80cf96
to
9002b37
Compare
stephanos
reviewed
Jun 10, 2024
| ResourceExhaustedScopeHeader, reErr.Scope.String(), | ||
| )) | ||
| if headerErr != nil { | ||
| logger.Error("Failed to add Resource-Exhausted headers to response", tag.Error(err)) |
There was a problem hiding this comment.
Shouldn't this be tag.Error(headerErr)? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add an interceptor for frontend service.
Interceptor will looks at error messages and replace unknown/internal messages to a common message
Why?
We are exposing/can expose to much of the internal details/customer info in errors.
Instead external error will be a simple message, and real error will be logged.
How did you test it?
Add unit test. Build/run tests
Potential risks
N/A
Documentation
N/A
Is hotfix candidate?
No