Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Steps and Sidecars to container_validation #7454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

professorabhay
Copy link

@professorabhay professorabhay commented Dec 2, 2023

Changes

Moved Steps and Sidecars functions to container_validation

closes #7442

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 2, 2023
Copy link

linux-foundation-easycla bot commented Dec 2, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: professorabhay / name: Abhay Kumar Gupta (e780f1a)

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2023
@tekton-robot
Copy link
Collaborator

Hi @professorabhay. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wlynch after the PR has been reviewed.
You can assign the PR to them by writing /assign @wlynch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@professorabhay
Copy link
Author

Hey, @JeromeJu!
Kindly take a look and let me know what else you want to see. 😊

@JeromeJu
Copy link
Member

JeromeJu commented Dec 4, 2023

Thanks @professorabhay
Looks like there are some cleanup needed for the imports.

/ok-to-test
/kind cleanup

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2023
@JeromeJu
Copy link
Member

JeromeJu commented Dec 4, 2023

For tekton release note template, we would need to leave a None release-note:
"```release-note
NONE
``

@tekton-robot
Copy link
Collaborator

@professorabhay: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-unit-tests e780f1a link true /test pull-tekton-pipeline-unit-tests
pull-tekton-pipeline-integration-tests e780f1a link true /test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-beta-integration-tests e780f1a link true /test pull-tekton-pipeline-beta-integration-tests
pull-tekton-pipeline-alpha-integration-tests e780f1a link true /test pull-tekton-pipeline-alpha-integration-tests
pull-tekton-pipeline-build-tests e780f1a link true /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 4, 2023
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2023
@tekton-robot
Copy link
Collaborator

@professorabhay: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dhruval7878
Copy link
Contributor

@professorabhay hey , i think tests are failing because you should import time and fmt packages in import statement and removing unused package like time and k8s.io/pkg/validation should do

@afrittoli
Copy link
Member

@professorabhay are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Steps and Sidecars to container_validation
5 participants