Stores the jwt token in a http cookie #354

pratap0007 · 2022-01-18T11:36:35Z

Adds a proxy to proxy the auth and rating endpoints

This proxy helps to configure the http cookies
in the client on ui side so that server can access it from .

Updates rating design to adds cookie and removes header

Adds implementation to manage http cookie on server

Adds endpoints for logout and get an accessToken
Updates rating api and use manual validation of jwt which
is fetched from cookie

Adds api endpoints in UI to fetch access token and logout

Adds /user/accesstoken endpoint on UI to get the access
toke for user to show it on user profile
Adds /user/logout to delete the http cookie on server

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
Run UI Unit Tests, Lint Checks with make ui-check
Commit messages follow commit message best practices

See the contribution guide for more details.

PuneetPunamiya · 2022-03-23T11:16:27Z

ui/src/setupProxy.js

+module.exports = function (app) {
+  app.use(
+    createProxyMiddleware(['/auth', '/user'], {
+      target: 'http://localhost:4200',


What will happen in case of production ?

I think we can use the env value of REDIRECT_URI instead of hard coding this value

yes ,we should get it from env

PuneetPunamiya · 2022-03-23T11:17:08Z

ui/src/setupProxy.js

+  );
+  app.use(
+    createProxyMiddleware(['/resource/**/rating'], {
+      target: 'http://localhost:8000',


same as above

PuneetPunamiya · 2022-03-23T11:21:04Z

api/pkg/auth/service/auth.go

@@ -62,6 +62,20 @@ type Service interface {
 	HubAuthenticate(res http.ResponseWriter, req *http.Request)
 }

+type cookie struct {


Can you move this struct to app.go

PuneetPunamiya · 2022-03-23T11:21:28Z

api/pkg/auth/service/auth.go

@@ -192,6 +206,27 @@ func (s *service) HubAuthenticate(res http.ResponseWriter, req *http.Request) {
 		return
 	}

+	//Add cookie and response and send it to in header
+


nit: can you please delete this blank line

PuneetPunamiya · 2022-03-23T11:23:54Z

api/pkg/service/rating/rating.go

-		db:     s.DB(ctx),
-		log:    s.Logger(ctx),
-		userID: validator.UserID(ctx),
+		db:     s.DB(newctx),


Why can't we use the same context ?

It was not adding userID in the context while doing jwtAuth validation

PuneetPunamiya · 2022-03-23T11:24:12Z

api/pkg/service/rating/rating_http_test.go

 	"github.com/tektoncd/hub/api/pkg/testutils"
 	goa "goa.design/goa/v3/pkg"
 )

 func GetChecker(tc *testutils.TestConfig) *goahttpcheck.APIChecker {
-	service := validator.NewService(tc.APIConfig, "rating")
+	// service := validator.NewService(tc.APIConfig, "rating")


Do we need this anymore ?

PuneetPunamiya · 2022-03-23T11:24:29Z

api/pkg/service/rating/rating_http_test.go

@@ -195,11 +194,11 @@ func TestGet_Http_ResourceNotFound(t *testing.T) {
 }

 func UpdateChecker(tc *testutils.TestConfig) *goahttpcheck.APIChecker {
-	service := validator.NewService(tc.APIConfig, "rating")
+	// service := validator.NewService(tc.APIConfig, "rating")


sm43 · 2022-05-23T06:06:00Z

/approve

if I want to curl the rating api .. how can i pass the token now?

tekton-robot · 2022-06-04T04:24:01Z

@pratap0007: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2022-09-02T05:01:22Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot · 2022-10-02T05:18:44Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot · 2022-11-01T05:43:50Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot · 2022-11-01T05:43:53Z

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

piyush-garg · 2022-11-14T09:23:34Z

/reopen

tekton-robot · 2022-11-14T09:23:37Z

@piyush-garg: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2022-11-14T09:23:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sm43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sm43]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2022-11-14T09:23:55Z

@pratap0007: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-hub-build-tests	`1e4cc7c`	link	true	`/test pull-tekton-hub-build-tests`
pull-tekton-hub-unit-tests	`1e4cc7c`	link	true	`/test pull-tekton-hub-unit-tests`
pull-tekton-hub-integration-tests	`1e4cc7c`	link	true	`/test pull-tekton-hub-integration-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

piyush-garg · 2022-11-14T09:24:02Z

/remove-lifecycle rotten

tekton-robot · 2023-02-12T10:12:08Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

pratap0007 · 2023-02-14T09:49:51Z

/remove-lifecycle stale

tekton-robot · 2023-03-16T10:26:04Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot · 2023-04-15T11:00:56Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot · 2023-04-15T11:00:58Z

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2022

tekton-robot requested review from PuneetPunamiya and sthaha January 18, 2022 11:36

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 18, 2022

pratap0007 force-pushed the server-cookie branch from 35d46a5 to 7b628d3 Compare March 1, 2022 12:14

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 1, 2022

pratap0007 force-pushed the server-cookie branch from 7b628d3 to 8b442f8 Compare March 1, 2022 12:20

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 1, 2022

pratap0007 force-pushed the server-cookie branch from 8b442f8 to da61bf3 Compare March 10, 2022 09:58

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022

pratap0007 marked this pull request as ready for review March 10, 2022 09:59

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022

pratap0007 force-pushed the server-cookie branch 2 times, most recently from 8fba34e to dcc8c89 Compare March 14, 2022 11:46

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2022

pratap0007 force-pushed the server-cookie branch from dcc8c89 to 915a437 Compare March 21, 2022 05:45

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2022

PuneetPunamiya reviewed Mar 23, 2022

View reviewed changes

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2022

pratap0007 force-pushed the server-cookie branch from 915a437 to 2582f72 Compare May 9, 2022 04:47

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2022

pratap0007 force-pushed the server-cookie branch from 73b9b4f to 1e4cc7c Compare May 12, 2022 12:54

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2022

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2022

tekton-robot added the lifecycle/stale label Sep 2, 2022

tekton-robot added lifecycle/rotten and removed lifecycle/stale labels Oct 2, 2022

tekton-robot closed this Nov 1, 2022

tekton-robot reopened this Nov 14, 2022

tekton-robot removed the lifecycle/rotten label Nov 14, 2022

tekton-robot added the lifecycle/stale label Feb 12, 2023

tekton-robot added lifecycle/rotten and removed lifecycle/stale labels Mar 16, 2023

tekton-robot closed this Apr 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stores the jwt token in a http cookie #354

Stores the jwt token in a http cookie #354

pratap0007 commented Jan 18, 2022 •

edited

Loading

PuneetPunamiya Mar 23, 2022

PuneetPunamiya Mar 23, 2022

pratap0007 Mar 24, 2022

PuneetPunamiya Mar 23, 2022

PuneetPunamiya Mar 23, 2022

PuneetPunamiya Mar 23, 2022

PuneetPunamiya Mar 23, 2022

pratap0007 Mar 28, 2022

PuneetPunamiya Mar 23, 2022

PuneetPunamiya Mar 23, 2022

sm43 commented May 23, 2022

tekton-robot commented Jun 4, 2022

tekton-robot commented Sep 2, 2022

tekton-robot commented Oct 2, 2022

tekton-robot commented Nov 1, 2022

tekton-robot commented Nov 1, 2022

piyush-garg commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

piyush-garg commented Nov 14, 2022

tekton-robot commented Feb 12, 2023

pratap0007 commented Feb 14, 2023

tekton-robot commented Mar 16, 2023

tekton-robot commented Apr 15, 2023

tekton-robot commented Apr 15, 2023

Stores the jwt token in a http cookie #354

Stores the jwt token in a http cookie #354

Conversation

pratap0007 commented Jan 18, 2022 • edited Loading

Submitter Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sm43 commented May 23, 2022

tekton-robot commented Jun 4, 2022

tekton-robot commented Sep 2, 2022

tekton-robot commented Oct 2, 2022

tekton-robot commented Nov 1, 2022

tekton-robot commented Nov 1, 2022

piyush-garg commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

piyush-garg commented Nov 14, 2022

tekton-robot commented Feb 12, 2023

pratap0007 commented Feb 14, 2023

tekton-robot commented Mar 16, 2023

tekton-robot commented Apr 15, 2023

tekton-robot commented Apr 15, 2023

pratap0007 commented Jan 18, 2022 •

edited

Loading