Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] feat: add events proto #227

Merged
merged 4 commits into from
Mar 10, 2022
Merged

[RFC] feat: add events proto #227

merged 4 commits into from
Mar 10, 2022

Conversation

elianiva
Copy link
Member

@elianiva elianiva commented Mar 7, 2022

  1. MouseScroll parameternya apa aja? possible ref: Delete publicroutes, privateroutes, and finalroutes #92
  2. Pake present tense atau past tense? (MouseClickRequest vs MouseClickedRequest)
  3. Mouse click biarin per-click atau per mouse-up / mouse-down ? disini, di bagian click features ada field buat ngitung seberapa lama user nahan mouse-down soalnya, tapi sekarang yg di-emit itu baru keydown doang jadi ga bisa dihitung lamanya

also, tadi pas buka filenya dapet error Import "enums.proto" was not found or had errors., gatau beneran error atau ngga

@elianiva elianiva added scope: backend Regarding the backend side needs review This PR needs some user reviews labels Mar 7, 2022
proto/Spectator.Protos/events.proto Outdated Show resolved Hide resolved
proto/Spectator.Protos/events.proto Outdated Show resolved Hide resolved
proto/Spectator.Protos/events.proto Outdated Show resolved Hide resolved
proto/Spectator.Protos/events.proto Outdated Show resolved Hide resolved
proto/Spectator.Protos/events.proto Outdated Show resolved Hide resolved
@elianiva
Copy link
Member Author

enumnya aku kasih suffix _BUTTON soalnya conflict sama enum Direction.

@ronnygunawan ronnygunawan merged commit 64a4519 into master Mar 10, 2022
@elianiva elianiva deleted the feat/events-proto branch March 11, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR needs some user reviews scope: backend Regarding the backend side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants