Silence initial client info #3218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run CI in merge queue
…_space_in_systemc Remove trailing space in system.c teeworlds#3220
…unused Mark unused NETMSG_SNAPSMALL for 0.8 removal teeworlds#3210
When a new player joins it is being sent all the client info of the currently connected tees. This is marked as non silent which is misleading because the client does not actually print these as join messages. The reason why the client does not print it is because it does not have its m_LocalClientID set yet. Setting it explicitly to silent makes it more obvious that this is not printing a chat message when reading the server code. This change will not change anything that can be witnessed by end users. This also ensures that when the client implementation changes it does not start printing unexpected "joined the game" messages in chat.
ChillerDragon
force-pushed
the
pr_silence_initial_client_info
branch
from
555030d
to
91b7164
Compare
github-merge-queue bot
pushed a commit
to teeworlds-community/teeworlds
that referenced
this pull request
Feb 23, 2024
Silence initial client info teeworlds#3218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new player joins it is being sent all the client info of the currently connected tees. This is marked as non silent which is misleading because the client does not actually print these as join messages. The reason why the client does not print it is because it does not have its m_LocalClientID set yet.
Setting it explicitly to silent makes it more obvious that this is not printing a chat message when reading the server code.
This change will not change anything that can be witnessed by end users.
This also ensures that when the client implementation changes it does not start printing unexpected "joined the game" messages in chat.