feat: add support for instance name #1491
Open
+115
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mShan0 <[email protected]> Co-authored-by: Arthur Schreiber <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
+ Coverage 80.66% 80.71% +0.04%
==========================================
Files 91 91
Lines 4655 4661 +6
Branches 854 858 +4
==========================================
+ Hits 3755 3762 +7
Misses 626 626
+ Partials 274 273 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nick-w-nick
reviewed
Oct 31, 2024
| if (this.config.options.port) { | ||
| return this.connectOnPort(this.config.options.port, this.config.options.multiSubnetFailover, signal); | ||
| } else { | ||
| // The instance lookup communicates with the server and gets all the | ||
| // available instance name and their corresponding ports. |
There was a problem hiding this comment.
Suggested change
| // available instance name and their corresponding ports. | |
| // available instance names and their corresponding ports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support for instance name, and store instance under rerouting data.
Co-authored-by: mShan0 [email protected]
Co-authored-by: Arthur Schreiber [email protected]