feat: add support for server name #1476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1476 +/- ##
==========================================
- Coverage 80.50% 80.41% -0.10%
==========================================
Files 91 91
Lines 4669 4673 +4
Branches 856 858 +2
==========================================
- Hits 3759 3758 -1
- Misses 634 637 +3
- Partials 276 278 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| * | ||
| * (no default) | ||
| */ | ||
| serverName?: string; |
There was a problem hiding this comment.
Small nit: Use servername instead, that would match the option name used by Node.js.
|
Hi @arthurschreiber , Just checked with David, for JDBC, then actually accept what user provided server name as a higher priority choice compare to server name from the routing. There also some other driver that will try to connect with both and connection with whichever connected successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have serverName in connection configuration, but the logic for actually using it config the cn name is missing. This PR added the logic. #1388