Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow onApply to accept either a synchronous or asynchronous function #483

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brandonmcconnell
Copy link
Contributor

  • Introduce MaybePromise and MaybeAsync type helpers
  • Allow onApply to accept either a synchronous or asynchronous function

Copy link

stackblitz bot commented Sep 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 7653594

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 12, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
svelte-ux ✅ Ready (View Log) Visit Preview 7653594

Copy link
Owner

@techniq techniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to also PR this to LayerStack, which is where 99% of Svelte UX's utils, actions, stores, etc will be living going forward.

I've extracted them as separate packages, and the LayerChart will soon only have a devDependency on Svelte UX after simplified PRs merge (LayerStack will also be getting a lot of utils from LayerChart for a common location that can be used in non-Svelte UX/LayerChart/and some cases Svelte projects.

Svelte UX will be updated to use @layerstack/* packages for most/all of these, and likely re-export to reduce the breaking change until closer to 1.0 (still debating)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants