Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NodeNext packages #281

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Support NodeNext packages #281

merged 5 commits into from
Mar 7, 2024

Conversation

techniq
Copy link
Owner

@techniq techniq commented Mar 6, 2024

Resolves #280

Copy link

cloudflare-pages bot commented Mar 6, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 762d169
Status: ✅  Deploy successful!
Preview URL: https://974abda8.svelte-ux.pages.dev
Branch Preview URL: https://moduleresolution-nodenext.svelte-ux.pages.dev

View logs

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-ux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 1:37am

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: 762d169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner Author

techniq commented Mar 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @techniq and the rest of your teammates on Graphite Graphite

@techniq
Copy link
Owner Author

techniq commented Mar 7, 2024

pnpm check | grep -B 1 -A 3 "Cannot find module" still has 4 failures in the root +page.svelte...

image

image

but since it's only docs related and doesn't break the build (until we resolve all warnings/errors in the #186) I think it's OK to ignore for now (could have even been failing prior to the change).

@techniq techniq merged commit c28c4b4 into main Mar 7, 2024
5 checks passed
@techniq techniq deleted the moduleresolution-nodenext branch March 7, 2024 01:47
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NodeNext packages
1 participant