Fixed TNTSearchTest::testSearchBoolean #232
Conversation
|
This space was added because of issues when searching words containing hyphens. Also, IMHO it is a more appropriate definition of boolean search operator. |
|
@ViliusS Was that issue around booleanSearch or just normal search? Currently in the testing for booleanSearch any search term that contains a hyphen is simply returning all the ids. I can continue to look into this issue while including the spaces in the boolean search operator if thats the way it should be formatted |
|
Check the links in the commit message itself. It was an issue when using boolean search. Adding space allows for more complex searches, for example "item1 -2020-04" would return all item1 results excluding creation date of April. Said that, I don't think that the test is broken. What is broken is the boolean search algorithm itself. For me it also returns all the ids almost all of the time. I'm still trying to find out what change broke it, but didn't had enough time to do this. It would be great if you could look into it. First suspect on my list is this change f2df690. |
removed the space that was added to the lex in 6b4c2c7