added sign in with facebook #1872
Conversation
There was a problem hiding this comment.
Apart from the other comments:
- Some of the tests fail. For the Sign In it might be possible that it is due to a missing test fixture (we use fixtures in the
backend/testto load test data into the database), i.e. a missing existing user. For the Sign Up something seems to be wrong with the State Cookie. - The Facebook provider is not considered in the
GetProviderfunction (see here)
| @@ -112,6 +118,9 @@ func (s *thirdPartySuite) setUpConfig(enabledProviders []string, allowedRedirect | |||
| cfg.ThirdParty.Providers.Discord.Enabled = true | |||
| case "microsoft": | |||
| cfg.ThirdParty.Providers.Microsoft.Enabled = true | |||
| case "facebook": | |||
| cfg.ThirdParty.Providers.Facebook.Enabled = true | |||
| } | |||
There was a problem hiding this comment.
This prevents tests from compiling.
| } |
| Config: &oauth2.Config{ | ||
| ClientID: config.ClientID, | ||
| ClientSecret: config.Secret, | ||
| Endpoint: facebook.Endpoint, |
There was a problem hiding this comment.
Using facebook.Endpoint from the golang.org/x/oauth2/facebook makes using some of the declared variables at the top obsolete, since they are not used (e.g. FacebookOauthAuthEndpoint) except for in tests. Also: it makes the tests (the added table test inthirdparty_auth_test.go) fail, because the API versions differ: it's v3.2 vs. v9.0. Furthermore: the Facebook API version is currently at v21.0 (see here) so I think we should use that unless there was a specific reason you used the old version(s)?
| Emails: []Email{ | ||
| { | ||
| Email: fbUser.Email, | ||
| Verified: true, // Facebook email is considered verified |
There was a problem hiding this comment.
|
/award 750 |
|
Awarding prathamesh0987: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/prathamesh0987 |
Description
Implement Facebook as social provider for third party logins.
Fixes #1657
Implementation
implements Facebook third party provider. Uses facebook Oauth to able to sign in
Tests
added test for facebook signup and signin.
Todos
create documentation in docs repo and add sign in with facebook to frontend