Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore backlinks to daily notes #32

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Ignore backlinks to daily notes #32

merged 4 commits into from
Nov 23, 2023

Conversation

vojto
Copy link
Collaborator

@vojto vojto commented Nov 23, 2023

Fixes https://height.app/dWwdXWnlP/T-2442

This fixes a serious problem that users saw who imported notes from LogSeq.

Sometimes they imported notes which had backlinks to daily notes which didn't exist.

And when we imported a backlink to another daily node, we would always import it as a regular note. So we basically created a regular note with id that looks just like a daily note.

And then the whole UI would just go bonkers because there should not be a regular note with id that looks like a daily note.

Perhaps the proper solution would be to derive daily-ness of a note from the ID, not from the dailyAt flag.

Copy link

github-actions bot commented Nov 23, 2023

size-limit report 📦

Path Size
dist/index.js 92.51 KB (+0.05% 🔺)

@vojto vojto requested review from maccman and ocavue November 23, 2023 07:40
Copy link

height bot commented Nov 23, 2023

This pull request has been linked to and will mark 1 task as "Done" when merged:

💡Tip: You can link multiple Height tasks to a pull request.

src/helpers/to-id.ts Outdated Show resolved Hide resolved
@vojto vojto merged commit e092e4e into master Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants