feat: implement duplicate row functionality #930
Conversation
Pull Request Test Coverage Report for Build 10951572039Details
💛 - Coveralls |
|
Oops, conflict leading to new feature(comment), fortunately it is easy to resolve, i'll review it. |
|
> Hi, I've been waiting too long for the merge pr.
|
| const onDuplicate = async (tableId: string, recordId: string) => { | ||
| await duplicateRecords(tableId, recordId, { | ||
| viewId: viewId || '', | ||
| anchorId: recordId, | ||
| position: 'after', | ||
| }); | ||
| toast({ description: t('expandRecord.duplicateRecord') }); | ||
| }; | ||
|
|
There was a problem hiding this comment.
After a successful duplicate, the current expand card should be updated with the new record, rather than just closing the expand card.
There was a problem hiding this comment.
Yes, I found it. I know that recordsServerData triggers rendering. When I duplicate record, the length of recordsServerData keep same. I don't know how to update RecordsServerData.
There was a problem hiding this comment.
Yes, I found it. I know that
recordsServerDatatriggers rendering. When I duplicate record, the length ofrecordsServerDatakeep same. I don't know how to update RecordsServerData.
In fact, recordsServerData will not be updated, recordsServerData is only the initialization data needed for ssr, and will not be used when the page is rendered and the socket is connected, so don't care about it!
There was a problem hiding this comment.
Oh, I see. Now I have to force refresh the page for the duplicated record to render. I have no cules to solve it.
There was a problem hiding this comment.
Try it.
// source
const createdRecords =await this.createRecords(tableId, createRecordsRo);
// aliternative
const createdRecords = await this.prismaService.$tx(
async () => {
return await this.createRecords(tableId, createRecordsRo);
}
);There was a problem hiding this comment.
thank you ,it works
When I started to implement the duplicate functionality, I actually did it . the comment in #796 (comment), let me implement it in expand card. I'm a little dissatisfied with the current implementation，it can't insert a duplicate record after the index of the target record. |
|
@boris-w hi, I have completed the pr. can you merge it? |
|
Looks like there's a problem merging some files. |
|
what can't files be merged. the result of ci is no conflicts with the base branch. so I don't know what to do next. |
It looks like you're using merge instead of rebase. |
AliceLanniste
force-pushed
the
duplicate_row_new
branch
from
042a2d2 to
06240f5
Compare
OK ，now it‘s work tree is clean |
close #796