Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better match empty text fields #1181

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

fix: better match empty text fields #1181

wants to merge 5 commits into from
+41 −19

Conversation

kpodp0ra
Copy link
Contributor

Context

This filter doesn't match empty strings, it only looks for nulls in database.

Changes

  1. Add e2e test for empty strings.1
  2. Added empty string matching to isEmpty filter.

Before this PR, only the first item would be matched. Now it matches the first and second one.

Footnotes

  1. In order to maintain readability, instead of adding another item to e2e, I re-branded the 20th field. ↩

@kpodp0ra kpodp0ra marked this pull request as draft December 20, 2024 14:20
@kpodp0ra
Copy link
Contributor Author

Working on aggregation fix:

@kpodp0ra kpodp0ra mentioned this pull request Dec 21, 2024
Open
@kpodp0ra
Copy link
Contributor Author

Waiting for 1183 issue to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kpodp0ra